You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
A comment here: the wording implies that None has a special meaning – but my understanding is that the spec makes no requirements of what objects libraries use to represent devices, and so adding special meaning to None is not really necessary.
In the motivating example, JAX doesn't use None to mean that "the default device is not predictable due to library specific device placement rules", it uses None to represent the concept of uncommitted placement on the default device.
JAX ... uses None to represent the concept of uncommitted placement on the default device.
This is one example of thea library specific device placement rule, I'd say :-).
That said, there's nothing special about the proposed wording here. Anything which says "None is allowed" is strictly better than what's in main, so if you've PR with a better wording, I'm happy to close this PR in favor of yours.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes gh-923.
Per discussion in the community meeting, https://hackmd.io/zn5bvdZTQIeJmb3RW1B-8g#Meeting-minutes-15-May-2025 and the resolution of #923 (comment), spell out explicitly that
Noneis an allowed return value of thedefault_device.